Skip to content

fix: removing tag #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2021
Merged

fix: removing tag #1173

merged 1 commit into from
Oct 7, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Oct 6, 2021

Description

Removing Unused tag in select component

Old:
image

New:
image

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner October 6, 2021 19:39
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1173 (f35357e) into main (9a66c03) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files         832      832           
  Lines       17223    17223           
  Branches     2238     2238           
=======================================
  Hits        14645    14645           
  Misses       2546     2546           
  Partials       32       32           
Impacted Files Coverage Δ
projects/components/src/select/select.component.ts 95.38% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a66c03...f35357e. Read the comment docs.

@palbizu palbizu merged commit 46c9863 into main Oct 7, 2021
@palbizu palbizu deleted the RemovingUnusedTag branch October 7, 2021 14:30
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Unit Test Results

    4 files  ±0  271 suites  ±0   17m 29s ⏱️ - 1m 44s
970 tests ±0  970 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
977 runs  ±0  977 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 46c9863. ± Comparison against base commit 9a66c03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants