Skip to content

fix: scrolling in waterfall fixed #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

jyothishjose6190
Copy link
Contributor

fixed: scrolling issue in waterfall chart
when the no of spans are more than the visible area, the expected behaviour is the user can scroll down and see the spans at the bottom. With the latest changes, scrolling is disabled

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@jyothishjose6190 jyothishjose6190 requested a review from a team as a code owner October 14, 2021 18:10
@jyothishjose6190
Copy link
Contributor Author

@itssharmasandeep please review this

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1191 (59cc1eb) into main (4494ac0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1191   +/-   ##
=======================================
  Coverage   85.02%   85.02%           
=======================================
  Files         832      832           
  Lines       17224    17224           
  Branches     2239     2239           
=======================================
  Hits        14645    14645           
  Misses       2547     2547           
  Partials       32       32           
Impacted Files Coverage Δ
...pi-trace-detail/api-trace-detail.page.component.ts 100.00% <ø> (ø)
.../pages/trace-detail/trace-detail.page.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4494ac0...59cc1eb. Read the comment docs.

@itssharmasandeep itssharmasandeep merged commit 550ce9d into hypertrace:main Oct 14, 2021
@github-actions
Copy link

Unit Test Results

    4 files  ±0  271 suites  ±0   18m 3s ⏱️ - 1m 48s
970 tests ±0  970 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
977 runs  ±0  977 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 550ce9d. ± Comparison against base commit 4494ac0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants