Skip to content

Feat/toggle switch control value accessor #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { CommonModule } from '@angular/common';
import { fakeAsync } from '@angular/core/testing';
import { FormsModule } from '@angular/forms';
import { FormControl, FormsModule, ReactiveFormsModule } from '@angular/forms';
import { MatSlideToggle, MatSlideToggleChange, MatSlideToggleModule } from '@angular/material/slide-toggle';
import { createHostFactory, Spectator } from '@ngneat/spectator/jest';
import { ToggleSwitchSize } from './toggle-switch-size';
Expand All @@ -12,7 +12,7 @@ describe('Toggle Switch Component', () => {
const createHost = createHostFactory({
component: ToggleSwitchComponent,
shallow: true,
imports: [MatSlideToggleModule, FormsModule, CommonModule]
imports: [MatSlideToggleModule, FormsModule, CommonModule, ReactiveFormsModule]
});

test('should pass properties to Mat Slide toggle correctly', fakeAsync(() => {
Expand Down Expand Up @@ -41,4 +41,20 @@ describe('Toggle Switch Component', () => {
spectator.triggerEventHandler(MatSlideToggle, 'change', new MatSlideToggleChange(matToggleComponent!, false));
expect(onCheckedChangeSpy).toHaveBeenCalledWith(false);
}));

test('should work correctly with control value accessor', () => {
const formControl = new FormControl(false);
spectator = createHost(`<ht-toggle-switch [label]="label" [formControl]="formControl"></ht-toggle-switch>`, {
hostProps: {
formControl: formControl
}
});
expect(spectator.component.isChecked).toBe(false);

formControl.setValue(true);
expect(spectator.component.isChecked).toBe(true);

formControl.disable();
expect(spectator.component.isDisabled).toBe(true);
});
});
71 changes: 60 additions & 11 deletions projects/components/src/toggle-switch/toggle-switch.component.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ChangeDetectionStrategy, Component, EventEmitter, Input, Output } from '@angular/core';
import { ChangeDetectionStrategy, ChangeDetectorRef, Component, EventEmitter, Input, Output } from '@angular/core';
import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';
import { MatSlideToggleChange } from '@angular/material/slide-toggle';
import { ToggleSwitchSize } from './toggle-switch-size';

Expand All @@ -10,33 +11,81 @@ import { ToggleSwitchSize } from './toggle-switch-size';
<div class="toggle-switch">
<mat-slide-toggle
color="primary"
[checked]="this.checked"
[ngClass]="{ 'small-slide-toggle': this.size === '${ToggleSwitchSize.Small}', disabled: this.disabled }"
[disabled]="this.disabled"
[checked]="this.isChecked"
[ngClass]="{ 'small-slide-toggle': this.size === '${ToggleSwitchSize.Small}', disabled: this.isDisabled }"
[disabled]="this.isDisabled"
(change)="this.onToggle($event)"
>
<div class="label">{{ this.label }}</div>
</mat-slide-toggle>
</div>
`
`,
providers: [
{
provide: NG_VALUE_ACCESSOR,
useExisting: ToggleSwitchComponent,
multi: true
}
]
})
export class ToggleSwitchComponent {
export class ToggleSwitchComponent implements ControlValueAccessor {
@Input()
public checked?: boolean;
public label?: string = '';

@Input()
public label?: string = '';
public size: ToggleSwitchSize = ToggleSwitchSize.Small;

@Input()
public disabled?: boolean;
public set checked(checked: boolean | undefined) {
this.isChecked = checked ?? false;
}

public get checked(): boolean {
return this.isChecked;
}

@Input()
public size: ToggleSwitchSize = ToggleSwitchSize.Small;
public set disabled(disabled: boolean | undefined) {
this.isDisabled = disabled ?? false;
}

public get disabled(): boolean {
return this.isDisabled;
}

@Output()
public readonly checkedChange: EventEmitter<boolean> = new EventEmitter();

public isChecked: boolean = false;
public isDisabled: boolean = false;

private onTouched!: () => void;
private onChanged!: (value: boolean) => void;

public constructor(private readonly cdr: ChangeDetectorRef) {}

public onToggle(toggleChange: MatSlideToggleChange): void {
this.checkedChange.emit(toggleChange.checked);
this.isChecked = toggleChange.checked;
this.checkedChange.emit(this.isChecked);
this.onChanged(this.isChecked);
this.onTouched();
}

public registerOnChange(fn: (value: boolean) => void): void {
this.onChanged = fn;
}

public registerOnTouched(fn: () => void): void {
this.onTouched = fn;
}

public setDisabledState(isDisabled: boolean): void {
this.isDisabled = isDisabled;
this.cdr.markForCheck();
}

public writeValue(isChecked: boolean | undefined): void {
this.isChecked = isChecked ?? false;
this.cdr.markForCheck();
}
}