Skip to content

refactor: adding a flex property to confirmation #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2022
Merged

refactor: adding a flex property to confirmation #1513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8d0a20
refactor: adding a flex property to confirmation
anandtiwary Mar 29, 2022
2fc5a37
Merge branch 'main' into confirmation-modal-styling
anandtiwary Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/components/src/confirmation/confirmation-modal.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
@include body-1-regular($gray-7);
text-align: center;
word-break: break-word;
flex: 1 1 auto;
overflow: hidden;
Comment on lines +18 to +19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason behind this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guy doesn't expand and takes up all the available space. So, if you put any custom content via the template as a child of this element, then its container height would be limited and the content would overflow. In order to show a scrollbar in its child template, we need to add this change here.

}

.controls {
Expand Down