Skip to content

refactor: allow async config for storage #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Conversation

aaron-steinfeld
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld commented Apr 7, 2022

Description

This change extends on the functionality added in #1517 . In the first PR, the functionality was added, but was not used. Now, an optional late-resolving config can be provided to the local and session storage services to support either config or runtime assignment for the entire application.

Testing

Updated existing tests, verified E2E

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1540 (e6b42fd) into main (80e7711) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1540   +/-   ##
=======================================
  Coverage   83.94%   83.95%           
=======================================
  Files         871      871           
  Lines       18655    18662    +7     
  Branches     2539     2539           
=======================================
+ Hits        15660    15667    +7     
  Misses       2873     2873           
  Partials      122      122           
Impacted Files Coverage Δ
projects/common/src/public-api.ts 100.00% <100.00%> (ø)
.../src/utilities/browser/storage/abstract-storage.ts 100.00% <100.00%> (ø)
...mon/src/utilities/browser/storage/local-storage.ts 100.00% <100.00%> (ø)
...n/src/utilities/browser/storage/session-storage.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e7711...e6b42fd. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Unit Test Results

       4 files  ±0     289 suites  ±0   20m 10s ⏱️ - 2m 19s
1 040 tests ±0  1 040 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 048 runs  ±0  1 048 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e6b42fd. ± Comparison against base commit 80e7711.

@aaron-steinfeld aaron-steinfeld marked this pull request as ready for review April 7, 2022 21:38
@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner April 7, 2022 21:38
@aaron-steinfeld aaron-steinfeld merged commit 1b3f662 into main Apr 8, 2022
@aaron-steinfeld aaron-steinfeld deleted the more-storage branch April 8, 2022 11:45
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Unit Test Results

       4 files  ±0     289 suites  ±0   22m 41s ⏱️ +12s
1 040 tests ±0  1 040 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 048 runs  ±0  1 048 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1b3f662. ± Comparison against base commit 80e7711.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants