Skip to content

refactor: only add aggregation in fragment if value is present #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Apr 22, 2021

Description

Please include a summary of the change, motivation and context.
refactor: only add aggregation in fragment if value is present

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner April 22, 2021 00:31
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #789 (ef4495e) into main (35b7136) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   85.41%   85.42%           
=======================================
  Files         792      792           
  Lines       16163    16167    +4     
  Branches     2061     2061           
=======================================
+ Hits        13806    13810    +4     
  Misses       2326     2326           
  Partials       31       31           
Impacted Files Coverage Δ
projects/distributed-tracing/src/public-api.ts 100.00% <100.00%> (ø)
...ification/explore/explore-specification-builder.ts 79.31% <100.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b7136...ef4495e. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 3722a76 into main Apr 22, 2021
@anandtiwary anandtiwary deleted the update-order-by branch April 22, 2021 16:31
@github-actions
Copy link

Unit Test Results

    4 files  ±0  250 suites  ±0   14m 38s ⏱️ -6s
897 tests ±0  897 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
903 runs  ±0  903 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3722a76. ± Comparison against base commit 35b7136.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants