Skip to content

feat: restayling radio group #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2021
Merged

feat: restayling radio group #792

merged 2 commits into from
Apr 26, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Apr 23, 2021

Description

The styles of the radio group were modified since the selection of the different radio buttons was not working correctly and also adjusted to the designs

Testing

Visual Testing.

Old:

image

New:

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team April 23, 2021 21:14
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #792 (3b625bd) into main (e2f46bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         792      792           
  Lines       16176    16176           
  Branches     2063     2063           
=======================================
  Hits        13819    13819           
  Misses       2326     2326           
  Partials       31       31           
Impacted Files Coverage Δ
...ects/components/src/radio/radio-group.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f46bb...3b625bd. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 3a0e542 into main Apr 26, 2021
@palbizu palbizu deleted the StylingRadioGroup branch April 26, 2021 13:38
@github-actions
Copy link

Unit Test Results

    4 files  ±0  250 suites  ±0   15m 17s ⏱️ -22s
897 tests ±0  897 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
903 runs  ±0  903 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3a0e542. ± Comparison against base commit e2f46bb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants