feat: adding note icon #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #801 +/- ##
=======================================
Coverage 85.42% 85.42%
=======================================
Files 792 792
Lines 16176 16176
Branches 2063 2063
=======================================
Hits 13819 13819
Misses 2326 2326
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
arjunlalb
reviewed
Apr 26, 2021
| @@ -78,6 +79,7 @@ export const enum IconType { | |||
| NoData = 'svg:noData', | |||
| Node = 'node', | |||
| None = 'none', | |||
| Note = 'svg:note', | |||
There was a problem hiding this comment.
both svgs page and note looks to be the same. If it already exists, could we reuse that and avoiding a new note icon?
There was a problem hiding this comment.
They are same, I liked note better name for that icon and more generic as it is used as description icon in the security tab inside settings.
I will be changing that on the traceable side once this is merged.
arjunlalb
approved these changes
Apr 26, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding note icon
Testing
Local testing done.