Skip to content

Fix table editable columns option #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2021

Conversation

jake-bassett
Copy link
Contributor

Description

This fixes some usability issues around the table column options button showing and also what we show for edit columns.

Before the button always showed, even when there were no options or when none of the columns are editable. The button will now hide if there is no benefit to the user by providing it, as in the above two examples.

@jake-bassett jake-bassett requested a review from a team as a code owner April 27, 2021 22:59
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #804 (9fe03c6) into main (767930f) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #804   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         792      792           
  Lines       16180    16191   +11     
  Branches     2067     2069    +2     
=======================================
+ Hits        13821    13831   +10     
- Misses       2328     2329    +1     
  Partials       31       31           
Impacted Files Coverage Δ
...able/columns/table-edit-columns-modal.component.ts 16.66% <0.00%> (ø)
...ble/header/table-header-cell-renderer.component.ts 77.38% <90.90%> (+2.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 767930f...9fe03c6. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit bf0e0dd into main Apr 29, 2021
@jake-bassett jake-bassett deleted the fix-table-editable-columns-option branch April 29, 2021 00:13
@github-actions
Copy link

Unit Test Results

    4 files  ±0  250 suites  ±0   14m 47s ⏱️ -39s
897 tests ±0  897 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
903 runs  ±0  903 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bf0e0dd. ± Comparison against base commit 767930f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants