Skip to content

feat: non resizable columns functionality in table #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2021

Conversation

itssharmasandeep
Copy link
Contributor

Description

Non resizable columns functionality in table

Testing

Local testing done

Checklist:

  • My changes generate no new warnings

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner May 3, 2021 09:17
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #813 (f433af1) into main (bc0622b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #813   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         792      792           
  Lines       16192    16197    +5     
  Branches     2069     2070    +1     
=======================================
+ Hits        13832    13837    +5     
  Misses       2329     2329           
  Partials       31       31           
Impacted Files Coverage Δ
...d/widgets/table/table-widget-renderer.component.ts 45.27% <ø> (ø)
projects/components/src/table/table.component.ts 91.24% <100.00%> (+0.06%) ⬆️
...dashboard/widgets/table/table-widget-base.model.ts 80.00% <100.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0622b...f433af1. Read the comment docs.

@github-actions

This comment has been minimized.

@anandtiwary
Copy link
Contributor

Looks fine to me. @jake-bassett Could you please check too?

@github-actions

This comment has been minimized.

@itssharmasandeep itssharmasandeep merged commit 342c20f into main May 3, 2021
@itssharmasandeep itssharmasandeep deleted the non-resizable-column branch May 3, 2021 17:27
@github-actions
Copy link

github-actions bot commented May 3, 2021

Unit Test Results

    4 files  250 suites   14m 27s ⏱️
897 tests 897 ✔️ 0 💤 0 ❌
903 runs  903 ✔️ 0 💤 0 ❌

Results for commit 342c20f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants