Table multiselect filters #823
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,58 +1,83 @@ | ||
| import { Dictionary } from '@hypertrace/common'; | ||
| import { FilterOperator } from '../../filtering/filter/filter-operators'; | ||
| import { TableFilter } from '../table-api'; | ||
|
|
||
| export const enum TableControlOptionType { | ||
| Filter = 'filter', | ||
| Property = 'property', | ||
| Unset = 'unset' | ||
| } | ||
|
|
||
| export type TableControlOption = TableUnsetControlOption | TableFilterControlOption | TablePropertyControlOption; | ||
|
|
||
| export interface TableFilterControlOption { | ||
| type: TableControlOptionType.Filter; | ||
| label: string; | ||
| metaValue: TableFilter; | ||
| } | ||
|
|
||
| export interface TableUnsetControlOption { | ||
| type: TableControlOptionType.Unset; | ||
| label: string; | ||
| metaValue: string; | ||
|
There was a problem hiding this comment. what is meta value supposed to do? How is it different than 'value' ? There was a problem hiding this comment. Please see this comment below. |
||
| } | ||
|
|
||
| export interface TablePropertyControlOption { | ||
| type: TableControlOptionType.Property; | ||
| label: string; | ||
| metaValue: Dictionary<unknown>; | ||
| } | ||
|
|
||
| /* | ||
| * Select Control | ||
| */ | ||
|
|
||
| export interface TableSelectControl { | ||
| placeholder: string; | ||
| options: TableSelectControlOption[]; | ||
| } | ||
|
|
||
| export interface TableSelectChange { | ||
| select: TableSelectControl; | ||
| values: TableSelectControlOption[]; | ||
| } | ||
|
|
||
| export type TableSelectControlOption = TableFilterControlOption; | ||
|
There was a problem hiding this comment. do we really need so many different types? Like below where you specify metaValue type There was a problem hiding this comment. I didn't add them just for fun! 😂 But valid question. I explain a little more in this comment. |
||
|
|
||
| /* | ||
| * Checkbox Control | ||
| */ | ||
|
|
||
| export interface TableCheckboxControl { | ||
| label: string; | ||
| value: boolean; | ||
| options: TableCheckboxOptions; | ||
| } | ||
|
|
||
| export interface TableCheckboxChange { | ||
| checkbox: TableCheckboxControl; | ||
| option: TableCheckboxControlOption; | ||
| } | ||
|
|
||
| export type TableCheckboxControlOption<T = boolean> = TableControlOption & { | ||
| value: T; | ||
| }; | ||
|
|
||
| export type TableCheckboxOptions = [TableCheckboxControlOption<true>, TableCheckboxControlOption<false>]; | ||
|
|
||
| /* | ||
| * Util | ||
| */ | ||
|
|
||
| export const toInFilter = (tableFilters: TableFilter[]): TableFilter => | ||
| tableFilters.reduce((previousValue, currentValue) => { | ||
| if (currentValue.operator !== FilterOperator.Equals || previousValue.field !== currentValue.field) { | ||
| throw Error('Filters must all contain same field and use = operator'); | ||
| } | ||
|
|
||
| return { | ||
| field: previousValue.field, | ||
| operator: FilterOperator.In, | ||
| value: [...(Array.isArray(previousValue.value) ? previousValue.value : [previousValue.value]), currentValue.value] | ||
| }; | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,7 @@ | ||
| import { TableControlOption } from '@hypertrace/components'; | ||
| import { Observable } from 'rxjs'; | ||
| import { GraphQlDataSourceModel } from './graphql-data-source.model'; | ||
|
|
||
| export abstract class GraphqlTableControlOptionsDataSourceModel extends GraphQlDataSourceModel<TableControlOption[]> { | ||
| public abstract getData(): Observable<TableControlOption[]>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,34 @@ | ||
| import { TableControlOption, TableControlOptionType, TableSelectControlOption } from '@hypertrace/components'; | ||
| import { Model, ModelProperty, STRING_PROPERTY } from '@hypertrace/hyperdash'; | ||
| import { Observable } from 'rxjs'; | ||
| import { map } from 'rxjs/operators'; | ||
| import { TableWidgetControlModel } from './table-widget-control.model'; | ||
|
|
||
| @Model({ | ||
| type: 'table-widget-select-option' | ||
| }) | ||
| export class TableWidgetControlSelectOptionModel extends TableWidgetControlModel<TableSelectControlOption> { | ||
| @ModelProperty({ | ||
| key: 'placeholder', | ||
| displayName: 'Placeholder', | ||
| type: STRING_PROPERTY.type, | ||
| required: true | ||
| }) | ||
| public placeholder!: string; | ||
|
|
||
| public getOptions(): Observable<TableSelectControlOption[]> { | ||
| return super.getOptions().pipe( | ||
| map(options => { | ||
| if (!this.isValidSelectControlOptions(options)) { | ||
| throw Error(`Invalid table widget select data source for options '${JSON.stringify(options)}'`); | ||
| } | ||
|
|
||
| return options; | ||
| }) | ||
| ); | ||
| } | ||
|
|
||
| private isValidSelectControlOptions(options: TableControlOption[]): options is TableSelectControlOption[] { | ||
| return options.every(option => option.type === TableControlOptionType.Filter); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a property control option? any visual example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see this comment below.