Skip to content

refactor: marking startTime as optional #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021
Merged

refactor: marking startTime as optional #827

merged 1 commit into from
May 7, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented May 7, 2021

Description

Please include a summary of the change, motivation and context.
refactor: marking startTime as optional

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner May 7, 2021 00:26
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #827 (b3d4765) into main (d1428d0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files         792      792           
  Lines       16222    16222           
  Branches     1930     1930           
=======================================
  Hits        13861    13861           
  Misses       2329     2329           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1428d0...b3d4765. Read the comment docs.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 9a0534a into main May 7, 2021
@anandtiwary anandtiwary deleted the fix-span-data branch May 7, 2021 01:35
@github-actions
Copy link

github-actions bot commented May 7, 2021

Unit Test Results

    4 files  ±0  250 suites  ±0   14m 31s ⏱️ -51s
899 tests ±0  899 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
905 runs  ±0  905 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9a0534a. ± Comparison against base commit d1428d0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants