Skip to content

refactor: make table scope optional #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Rather than requiring dummy implementations of getScope everywhere, this allows omitting it if not needed.

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner May 11, 2021 16:13
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #841 (0d9990a) into main (80af206) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #841   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files         793      793           
  Lines       16252    16252           
  Branches     1932     1932           
=======================================
  Hits        13886    13886           
  Misses       2334     2334           
  Partials       32       32           
Impacted Files Coverage Δ
...d/widgets/table/table-widget-renderer.component.ts 48.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80af206...0d9990a. Read the comment docs.

@aaron-steinfeld aaron-steinfeld merged commit 07602d7 into main May 11, 2021
@aaron-steinfeld aaron-steinfeld deleted the make-table-scope-optional branch May 11, 2021 16:28
@github-actions
Copy link

Unit Test Results

    4 files  ±0  250 suites  ±0   15m 39s ⏱️ + 1m 2s
899 tests ±0  899 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
905 runs  ±0  905 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 07602d7. ± Comparison against base commit 80af206.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants