feat: adding download icon #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunlalb
reviewed
May 18, 2021
| @@ -0,0 +1,3 @@ | |||
| <svg width="20" height="18" viewBox="0 0 20 18" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
| <path fill-rule="evenodd" clip-rule="evenodd" d="M13.5858 6L11 8.58579V1C11 0.447715 10.5523 0 10 0C9.44771 0 9 0.447715 9 1V8.58579L6.41421 6C6.02369 5.60948 5.39052 5.60948 5 6C4.60948 6.39052 4.60948 7.02369 5 7.41421L9.29289 11.7071C9.68342 12.0976 10.3166 12.0976 10.7071 11.7071L15 7.41421C15.3905 7.02369 15.3905 6.39052 15 6C14.6095 5.60948 13.9763 5.60948 13.5858 6ZM20 13C20 12.4477 19.5523 12 19 12C18.4477 12 18 12.4477 18 13V16H2V13C2 12.4477 1.55228 12 1 12C0.447715 12 0 12.4477 0 13V16C0 17.1046 0.89543 18 2 18H18C19.1046 18 20 17.1046 20 16V13Z" fill="#272C2E"/> | |||
There was a problem hiding this comment.
fill should be currentColor
There was a problem hiding this comment.
I just copy pasted from mock
Codecov Report
@@ Coverage Diff @@
## main #857 +/- ##
=======================================
Coverage 85.47% 85.47%
=======================================
Files 797 797
Lines 16351 16351
Branches 1955 1955
=======================================
Hits 13976 13976
Misses 2343 2343
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
arjunlalb
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding download icon to the hypertrace icon library.
Testing
Local testing done.
Checklist: