Skip to content

feat: memoize record method call so it is only called once #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2021

Conversation

jake-bassett
Copy link
Contributor

Description

Small fix to memoize call to getLogEventAttributeRecords. This stops it from calling multiple times and triggering change detection in ht-list-view.

@jake-bassett jake-bassett requested a review from a team as a code owner May 18, 2021 18:12
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #858 (5294178) into main (1b54d53) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         797      797           
  Lines       16351    16351           
  Branches     1955     1955           
=======================================
  Hits        13976    13976           
  Misses       2343     2343           
  Partials       32       32           
Impacted Files Coverage Δ
...omponents/log-events/log-events-table.component.ts 77.77% <ø> (ø)
...d/components/log-events/log-events-table.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b54d53...5294178. Read the comment docs.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit 0495b2d into main May 18, 2021
@jake-bassett jake-bassett deleted the ENG-9177-fix-non-selectable-log-event-key-values branch May 18, 2021 18:18
@github-actions
Copy link

Unit Test Results

    4 files  ±0  252 suites  ±0   15m 21s ⏱️ +35s
908 tests ±0  908 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
914 runs  ±0  914 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0495b2d. ± Comparison against base commit 1b54d53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants