Skip to content

feat: remove create option when empty searchString #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2021

Conversation

jake-bassett
Copy link
Contributor

Description

Removes the "Create" option when no search text is provided.

@jake-bassett jake-bassett requested a review from a team as a code owner May 18, 2021 20:04
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #859 (b480e33) into main (0495b2d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
- Coverage   85.47%   85.41%   -0.06%     
==========================================
  Files         797      797              
  Lines       16351    16356       +5     
  Branches     1955     1958       +3     
==========================================
- Hits        13976    13971       -5     
- Misses       2343     2353      +10     
  Partials       32       32              
Impacted Files Coverage Δ
...ts/components/src/combo-box/combo-box.component.ts 83.10% <100.00%> (-6.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0495b2d...b480e33. Read the comment docs.

@github-actions

This comment has been minimized.

@jake-bassett jake-bassett merged commit ee7bd72 into main May 18, 2021
@jake-bassett jake-bassett deleted the update-autocomplete branch May 18, 2021 21:21
@github-actions
Copy link

Unit Test Results

    4 files  ±0  252 suites  ±0   14m 51s ⏱️ -30s
908 tests ±0  908 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
914 runs  ±0  914 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ee7bd72. ± Comparison against base commit 0495b2d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants