fix: combo-box dropdown overflow-x #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #860 +/- ##
=======================================
Coverage 85.41% 85.41%
=======================================
Files 797 797
Lines 16356 16356
Branches 1958 1958
=======================================
Hits 13971 13971
Misses 2353 2353
Partials 32 32 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
May 19, 2021
| @@ -108,6 +108,7 @@ | |||
|
|
|||
| .option-list { | |||
| overflow-y: auto; | |||
| overflow-x: hidden; | |||
There was a problem hiding this comment.
So it will clip it? Should we put ellipsis here?
There was a problem hiding this comment.
It doesn't clip in my testing. This just fixes that few pixel overflow that adds a mostly useless scrollbar.
anandtiwary
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove horizontal scrollbar from combo-box dropdown.