fix: changing card hover behaviour #875
Conversation
Codecov Report
@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 799 799
Lines 16434 16434
Branches 2064 2064
=======================================
Hits 14029 14029
Misses 2373 2373
Partials 32 32 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -9,12 +9,16 @@ | |||
|
|
|||
| @mixin card-hover { | |||
| &:hover { | |||
| @include dropdown-box-shadow(); | |||
| @include box-shadow-2dp(); | |||
| cursor: pointer; | |||
| } | |||
| } | |||
|
|
|||
| @mixin filter-box-shadow { | |||
There was a problem hiding this comment.
nit: why the 2 separate mixins defined the same?
This comment has been minimized.
This comment has been minimized.
|
@alok-traceable Could you please share a before and after screenshot? |
| @@ -33,21 +34,13 @@ | |||
| } | |||
|
|
|||
| &:hover { | |||
| background: $blue-2; | |||
There was a problem hiding this comment.
We don't want to show a darker blue when user hover on selected card?
There was a problem hiding this comment.
Need to remove these on hover on card
- border
- background color change
To maintain consistency on hover elements, selected and un-selected cards should follow the same behavior.
I can revert this change if required.
This comment has been minimized.
This comment has been minimized.
Description
Global changes on card component hover behavior.
Testing
Verified on the local environment. Mostly all changes are on stylings.
Checklist: