Skip to content

feat: table cell no-op parser update #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2021
Merged

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented May 24, 2021

Description

Table Cell NoOp was updated to allow single data in the parser

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from aaron-steinfeld May 24, 2021 16:30
@palbizu palbizu requested a review from a team as a code owner May 24, 2021 16:30
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #876 (ccfd2af) into main (f45651b) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files         799      799           
  Lines       16428    16428           
  Branches     2062     2062           
=======================================
  Hits        14023    14023           
  Misses       2373     2373           
  Partials       32       32           
Impacted Files Coverage Δ
...able/cells/data-parsers/table-cell-no-op-parser.ts 88.88% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45651b...ccfd2af. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit cadf4b6 into main May 24, 2021
@palbizu palbizu deleted the TableCellNoOpParserUpdate branch May 24, 2021 18:46
@github-actions
Copy link

Unit Test Results

    4 files  ±0  254 suites  ±0   15m 11s ⏱️ +40s
914 tests ±0  914 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
920 runs  ±0  920 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cadf4b6. ± Comparison against base commit f45651b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants