Skip to content

feat: generic number input component with min-max support #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2021

Conversation

arjunlalb
Copy link
Contributor

Description

Number input component with support for min and max values.

Testing

Manually verified. UTs added.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner May 26, 2021 10:10
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #879 (0639131) into main (7eec180) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
+ Coverage   85.33%   85.35%   +0.02%     
==========================================
  Files         799      801       +2     
  Lines       16440    16466      +26     
  Branches     2064     2066       +2     
==========================================
+ Hits        14029    14055      +26     
  Misses       2379     2379              
  Partials       32       32              
Impacted Files Coverage Δ
...ponents/src/number-input/number-input.component.ts 100.00% <100.00%> (ø)
...components/src/number-input/number-input.module.ts 100.00% <100.00%> (ø)
projects/components/src/public-api.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eec180...0639131. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 3c3be3d into main May 26, 2021
@arjunlalb arjunlalb deleted the number-input-component branch May 26, 2021 13:11
@github-actions
Copy link

Unit Test Results

    4 files  ±0  255 suites  +1   14m 50s ⏱️ + 1m 8s
921 tests +4  921 ✔️ +4  0 💤 ±0  0 ❌ ±0 
927 runs  +4  927 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 3c3be3d. ± Comparison against base commit 7eec180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants