Skip to content

fix: adding hyperlink capabilities to nav items and nav tabs #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2021

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented May 28, 2021

Description

Please include a summary of the change, motivation and context.
fix: adding hyperlink capabilities to nav items and nav tabs

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner May 28, 2021 03:57
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #885 (f5d7615) into main (cc56d63) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   85.35%   85.35%   -0.01%     
==========================================
  Files         801      801              
  Lines       16468    16473       +5     
  Branches     2067     2067              
==========================================
+ Hits        14057    14061       +4     
- Misses       2379     2380       +1     
  Partials       32       32              
Impacted Files Coverage Δ
...rc/tabs/navigable/navigable-tab-group.component.ts 44.44% <50.00%> (-2.62%) ⬇️
...ents/src/navigation/nav-item/nav-item.component.ts 100.00% <100.00%> (ø)
...onents/src/navigation/navigation-list.component.ts 84.00% <100.00%> (-1.19%) ⬇️
...omponents/src/navigation/navigation-list.module.ts 100.00% <100.00%> (ø)
...ponents/src/tabs/navigable/navigable-tab.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc56d63...f5d7615. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb
Copy link
Contributor

Nice!

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 5ea1852 into main May 28, 2021
@anandtiwary anandtiwary deleted the nav-hyperlinks branch May 28, 2021 15:33
@github-actions
Copy link

Unit Test Results

    4 files  ±0  256 suites  +1   13m 22s ⏱️ - 2m 35s
923 tests +1  923 ✔️ +1  0 💤 ±0  0 ❌ ±0 
929 runs  +1  929 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 5ea1852. ± Comparison against base commit cc56d63.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants