Skip to content

feat: Adding form field wrapper #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2021
Merged

feat: Adding form field wrapper #895

merged 3 commits into from
Jun 1, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Jun 1, 2021

Description

A new component was created that works as a wrapper for the label, icon, and input field to have a standard to insert in the different components. The component allows attaching any input field present in the library

Testing

Unit test and visual test.

image

References:

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner June 1, 2021 14:53
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #895 (ad32e44) into main (47c4b62) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
+ Coverage   85.37%   85.38%   +0.01%     
==========================================
  Files         801      803       +2     
  Lines       16475    16492      +17     
  Branches     2067     2067              
==========================================
+ Hits        14065    14082      +17     
  Misses       2378     2378              
  Partials       32       32              
Impacted Files Coverage Δ
.../components/src/form-field/form-field.component.ts 100.00% <100.00%> (ø)
...cts/components/src/form-field/form-field.module.ts 100.00% <100.00%> (ø)
projects/components/src/public-api.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c4b62...ad32e44. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@arjunlalb arjunlalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this :)

@github-actions

This comment has been minimized.

@palbizu palbizu requested review from anandtiwary and arjunlalb June 1, 2021 19:39
@palbizu palbizu merged commit a270568 into main Jun 1, 2021
@palbizu palbizu deleted the FormFieldElement branch June 1, 2021 23:31
@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Unit Test Results

    4 files  ±0  257 suites  +1   14m 52s ⏱️ -27s
925 tests +2  925 ✔️ +2  0 💤 ±0  0 ❌ ±0 
931 runs  +2  931 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit a270568. ± Comparison against base commit 47c4b62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants