Skip to content

fix: word wrap update for confirmation modal content #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

arjunlalb
Copy link
Contributor

Description

word wrap update for confirmation modal content

@arjunlalb arjunlalb requested a review from a team as a code owner June 4, 2021 16:49
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #903 (bd7439f) into main (00dc01c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         803      803           
  Lines       16496    16496           
  Branches     2069     2069           
=======================================
  Hits        14085    14085           
  Misses       2379     2379           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00dc01c...bd7439f. Read the comment docs.

@github-actions

This comment has been minimized.

@@ -14,7 +14,7 @@
.description {
@include body-1-regular($gray-7);
text-align: center;
word-break: break-all;
word-break: break-word;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any side effects of this change? Possibly on API DNA - mark sensitive data side?

cc @jake-bassett

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be fine. Tested at few places. Looked alright. We are just going from breaking mid-word to a more readable word break.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if you tested it.

@arjunlalb arjunlalb merged commit 6a9fc28 into main Jun 4, 2021
@arjunlalb arjunlalb deleted the word-wrap-fix branch June 4, 2021 17:53
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Unit Test Results

    4 files  ±0  257 suites  ±0   13m 49s ⏱️ - 2m 5s
926 tests ±0  926 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
932 runs  ±0  932 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6a9fc28. ± Comparison against base commit 00dc01c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants