Skip to content

fix: form field small fix #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2021
Merged

fix: form field small fix #904

merged 2 commits into from
Jun 4, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Jun 4, 2021

Description

Form Field small fixes.

  • Removing unused padding
  • Removing empty div when it has no label.

Testing

File Inspection.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner June 4, 2021 18:59
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #904 (f7aa3c0) into main (6a9fc28) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         803      803           
  Lines       16496    16496           
  Branches     2069     2069           
=======================================
  Hits        14085    14085           
  Misses       2379     2379           
  Partials       32       32           
Impacted Files Coverage Δ
.../components/src/form-field/form-field.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9fc28...f7aa3c0. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit b213da2 into main Jun 4, 2021
@palbizu palbizu deleted the FormFieldFix branch June 4, 2021 19:33
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Unit Test Results

    4 files  ±0  257 suites  ±0   15m 12s ⏱️ + 1m 23s
926 tests ±0  926 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
932 runs  ±0  932 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b213da2. ± Comparison against base commit 6a9fc28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants