feat: log records in a new tab #916
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { ChangeDetectionStrategy, Component } from '@angular/core'; | ||
| import { Observable } from 'rxjs'; | ||
| import { LogEventsTableViewType } from '../../../shared/components/log-events/log-events-table.component'; | ||
| import { LogEvent } from '../../../shared/dashboard/widgets/waterfall/waterfall/waterfall-chart'; | ||
| import { TraceDetailService } from './../trace-detail.service'; | ||
|
|
||
| @Component({ | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| template: ` | ||
| <ng-container *ngIf="this.logEvents$ | async as logEvents"> | ||
| <ht-log-events-table | ||
| [logEvents]="logEvents" | ||
| logEventsTableViewType="${LogEventsTableViewType.Detailed}" | ||
| ></ht-log-events-table> | ||
| </ng-container> | ||
| ` | ||
| }) | ||
| export class TraceLogsComponent { | ||
|
There was a problem hiding this comment. So this is not a dash page. It works. But I am not sure if we should be diverge from the dashboard pattern. @aaron-steinfeld thoughts? There was a problem hiding this comment. IMO, we should try to reign dashboards back in to pages that look like dashboards. If we later need to embed this as a widget in another page, we could widgetize it for sharing at that point - but no need to build these custom single-page, single-purpose widgets. |
||
| public readonly logEvents$: Observable<LogEvent[]>; | ||
|
|
||
| public constructor(private readonly traceDetailService: TraceDetailService) { | ||
| this.logEvents$ = this.traceDetailService.fetchLogEvents(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { ChangeDetectionStrategy, Component } from '@angular/core'; | ||
| import { Observable } from 'rxjs'; | ||
| import { map } from 'rxjs/operators'; | ||
| import { TraceDetailService } from './../trace-detail.service'; | ||
| import { traceSequenceDashboard } from './trace-sequence.dashboard'; | ||
|
|
||
| @Component({ | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| template: ` | ||
| <ht-navigable-dashboard | ||
| *htLoadAsync="this.traceVariables$ as traceVariables" | ||
| class="scrollable-container" | ||
| [padding]="0" | ||
| [variables]="traceVariables" | ||
| navLocation="${traceSequenceDashboard.location}" | ||
| > | ||
| </ht-navigable-dashboard> | ||
| ` | ||
| }) | ||
| export class TraceSequenceComponent { | ||
| public readonly traceVariables$: Observable<TraceDetailVariables>; | ||
|
|
||
| public constructor(private readonly traceDetailService: TraceDetailService) { | ||
| this.traceVariables$ = this.traceDetailService.fetchTraceDetails().pipe( | ||
| map(details => ({ | ||
| traceId: details.id, | ||
| startTime: details.startTime, | ||
| spanId: details.entrySpanId | ||
| })) | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| interface TraceDetailVariables { | ||
| traceId: string; | ||
| startTime?: string | number; | ||
| spanId?: string; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,4 +45,8 @@ | |
| .summary-value { | ||
| margin-right: 24px; | ||
| } | ||
|
|
||
| .tabs { | ||
| margin-top: 16px; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are fetching from graphql then we should use
*htLoadAsyncso that we can show the loader iconThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, for this
Data is already being fetched before this, on the page level. and here it will be only used as a static data observable (
shareReplay)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay. I hope that doesn't change :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to use loadAsync. If in case fetchLogEvents starts returning a new observable, we would have to remember to update this template as well.