feat: adding options alignment in Radio Group #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #918 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 803 803
Lines 16508 16509 +1
Branches 2073 2073
=======================================
+ Hits 14089 14090 +1
Misses 2387 2387
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Jun 9, 2021
jake-bassett
approved these changes
Jun 9, 2021
This comment has been minimized.
This comment has been minimized.
arjunlalb
reviewed
Jun 9, 2021
| @@ -39,6 +40,9 @@ export class RadioGroupComponent implements OnInit { | |||
| @Input() | |||
| public disabled: boolean | undefined; | |||
|
|
|||
| @Input() | |||
| public optionsDirection: OptionsDirection = OptionsDirection.Column; | |||
There was a problem hiding this comment.
this is an input within the radiogroup component. so it can use a simpler name. perhaps just orientation or direction?
There was a problem hiding this comment.
not a bad update to make (I'd opt for orientation, and update the enum too to something like RadioGroupOrientation), worth doing before this gets consumed anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the attribute to configure horizontal/vertical options alignment from Radio Group (column default alignment).
Testing
Visual Testing
Row View:
Column View:
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.