Skip to content

feat: add custom configurations to the topology widget #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2021

Conversation

itssharmasandeep
Copy link
Contributor

Description

Add custom configurations to the topology widget

  • Make legend optional
  • Make minimap/brush optional
  • Add zoom to fit configuration

Testing

Local testing done

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner June 18, 2021 12:18
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #938 (07c544b) into main (3d7da37) will decrease coverage by 0.14%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   85.21%   85.07%   -0.15%     
==========================================
  Files         812      812              
  Lines       16714    16722       +8     
  Branches     2003     2004       +1     
==========================================
- Hits        14243    14226      -17     
- Misses       2439     2464      +25     
  Partials       32       32              
Impacted Files Coverage Δ
...y/src/shared/components/topology/d3/d3-topology.ts 91.95% <ø> (ø)
...ets/topology/topology-widget-renderer.component.ts 97.91% <ø> (ø)
...ractions/topology-interaction-control.component.ts 51.11% <80.00%> (+1.11%) ⬆️
...c/shared/components/topology/topology.component.ts 95.83% <100.00%> (+0.37%) ⬆️
...ashboard/widgets/topology/topology-widget.model.ts 81.81% <100.00%> (+6.81%) ⬆️
...ity/src/shared/components/utils/d3/zoom/d3-zoom.ts 57.25% <0.00%> (-10.49%) ⬇️
...c/shared/components/utils/d3/trace-d3-selection.ts 75.75% <0.00%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7da37...07c544b. Read the comment docs.

@github-actions

This comment has been minimized.

arjunlalb
arjunlalb previously approved these changes Jun 18, 2021
@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit f70fb6c into main Jun 18, 2021
@arjunlalb arjunlalb deleted the custom-config-topology branch June 18, 2021 12:39
@github-actions
Copy link

Unit Test Results

    4 files  ±0  259 suites  ±0   14m 46s ⏱️ +49s
936 tests ±0  936 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
942 runs  ±0  942 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f70fb6c. ± Comparison against base commit 3d7da37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants