Skip to content

feat: add support for description in radio button #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2021

Conversation

arjunlalb
Copy link
Contributor

Description

add support for description in radio button

Testing

Manually verified. UTs added.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Screenshot 2021-06-25 at 10 18 33 PM

Screenshot 2021-06-25 at 10 15 30 PM

@arjunlalb arjunlalb requested a review from a team as a code owner June 25, 2021 16:56
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #946 (44f117c) into main (6cca58d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files         812      812           
  Lines       16723    16723           
  Branches     2004     2004           
=======================================
  Hits        14223    14223           
  Misses       2468     2468           
  Partials       32       32           
Impacted Files Coverage Δ
...ects/components/src/radio/radio-group.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cca58d...44f117c. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 3c36e74 into main Jun 26, 2021
@arjunlalb arjunlalb deleted the radio-button-description-support branch June 26, 2021 02:45
@github-actions
Copy link

Unit Test Results

    4 files  ±0  259 suites  ±0   14m 45s ⏱️ +3s
937 tests +1  937 ✔️ +1  0 💤 ±0  0 ❌ ±0 
943 runs  +1  943 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 3c36e74. ± Comparison against base commit 6cca58d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants