-
Notifications
You must be signed in to change notification settings - Fork 11
Fix global link params #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #948 +/- ##
==========================================
- Coverage 85.07% 85.05% -0.03%
==========================================
Files 812 812
Lines 16723 16723
Branches 2004 2004
==========================================
- Hits 14227 14223 -4
- Misses 2464 2468 +4
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but would recommend @anandtiwary also take a look
Description
Global params weren't updating after a link was generated. Need to watch query params and regenerate
Testing
Manual, updated ut
Checklist: