Skip to content

Fix global link params #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 26, 2021
Merged

Fix global link params #948

merged 14 commits into from
Jun 26, 2021

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Global params weren't updating after a link was generated. Need to watch query params and regenerate

Testing

Manual, updated ut

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner June 25, 2021 21:55
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #948 (fd870bb) into main (c039beb) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
- Coverage   85.07%   85.05%   -0.03%     
==========================================
  Files         812      812              
  Lines       16723    16723              
  Branches     2004     2004              
==========================================
- Hits        14227    14223       -4     
- Misses       2464     2468       +4     
  Partials       32       32              
Impacted Files Coverage Δ
...ojects/common/src/navigation/navigation.service.ts 85.71% <33.33%> (-2.82%) ⬇️
projects/components/src/link/link.component.ts 100.00% <100.00%> (ø)
projects/components/src/link/link.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c039beb...fd870bb. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@jake-bassett jake-bassett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but would recommend @anandtiwary also take a look

@aaron-steinfeld aaron-steinfeld merged commit 6cca58d into main Jun 26, 2021
@aaron-steinfeld aaron-steinfeld deleted the fix-global-link-params branch June 26, 2021 00:46
@github-actions
Copy link

Unit Test Results

    4 files  ±0  259 suites  ±0   14m 42s ⏱️ +16s
936 tests ±0  936 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
942 runs  ±0  942 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6cca58d. ± Comparison against base commit c039beb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants