Skip to content

fix: build initiial nav params on observable #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Conversation

aaron-steinfeld
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld commented Jun 26, 2021

Description

Link observable was only emitting after a change in route, so initial state was empty.

Testing

Manual

@aaron-steinfeld aaron-steinfeld marked this pull request as ready for review June 26, 2021 13:49
@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner June 26, 2021 13:49
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #949 (10b98c8) into main (3c36e74) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #949   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files         812      812           
  Lines       16723    16723           
  Branches     2004     2004           
=======================================
  Hits        14223    14223           
  Misses       2468     2468           
  Partials       32       32           
Impacted Files Coverage Δ
...ojects/common/src/navigation/navigation.service.ts 85.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c36e74...10b98c8. Read the comment docs.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit b909313 into main Jun 26, 2021
@arjunlalb arjunlalb deleted the fix-link-again branch June 26, 2021 15:17
@github-actions
Copy link

Unit Test Results

    4 files  ±0  259 suites  ±0   15m 44s ⏱️ +59s
937 tests ±0  937 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
943 runs  ±0  943 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b909313. ± Comparison against base commit 3c36e74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants