Skip to content

fix: log records bug fixes #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2021
Merged

fix: log records bug fixes #958

merged 2 commits into from
Jul 1, 2021

Conversation

itssharmasandeep
Copy link
Contributor

@itssharmasandeep itssharmasandeep commented Jun 29, 2021

Description

  • Bug fixes in marker indicator.
    1. Wrong number of logs are there in the tooltip for marker (on hover)
    2. Wrong summary is there in the tooltip for marker (on hover)
  • New column span_id in log records table

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner June 29, 2021 07:29
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #958 (6fcbca7) into main (0745f3d) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
- Coverage   85.04%   85.04%   -0.01%     
==========================================
  Files         812      812              
  Lines       16741    16742       +1     
  Branches     2164     2165       +1     
==========================================
  Hits        14238    14238              
- Misses       2472     2473       +1     
  Partials       31       31              
Impacted Files Coverage Δ
...omponents/log-events/log-events-table.component.ts 70.00% <ø> (ø)
...s/waterfall/waterfall/waterfall-chart.component.ts 46.23% <0.00%> (-0.51%) ⬇️
...sequence/renderer/sequence-bar-renderer.service.ts 94.00% <100.00%> (ø)
...c/shared/services/log-events/log-events.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0745f3d...6fcbca7. Read the comment docs.

@github-actions

This comment has been minimized.

@@ -230,7 +230,7 @@ export class SequenceBarRendererService {
? scaledEnd - this.markerWidth - 2
: marker.markerTime
});
markerTime = scaledNormalizedMarkers[index].markerTime;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we not need normalized markers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the terminology I have used,
No other significance of it than grouping the scaled markers
If you could suggest the better naming for this?

@anandtiwary
Copy link
Contributor

Looks good apart from the two questions

@github-actions

This comment has been minimized.

@itssharmasandeep itssharmasandeep merged commit 4e56e26 into main Jul 1, 2021
@itssharmasandeep itssharmasandeep deleted the log-records-bug-fix branch July 1, 2021 07:46
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

Unit Test Results

    4 files  ±0  259 suites  ±0   14m 53s ⏱️ +37s
937 tests ±0  937 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
943 runs  ±0  943 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4e56e26. ± Comparison against base commit 0745f3d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants