-
Notifications
You must be signed in to change notification settings - Fork 11
fix: log records bug fixes #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #958 +/- ##
==========================================
- Coverage 85.04% 85.04% -0.01%
==========================================
Files 812 812
Lines 16741 16742 +1
Branches 2164 2165 +1
==========================================
Hits 14238 14238
- Misses 2472 2473 +1
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
...ibuted-tracing/src/shared/dashboard/widgets/waterfall/waterfall/waterfall-chart.component.ts
Show resolved
Hide resolved
@@ -230,7 +230,7 @@ export class SequenceBarRendererService { | |||
? scaledEnd - this.markerWidth - 2 | |||
: marker.markerTime | |||
}); | |||
markerTime = scaledNormalizedMarkers[index].markerTime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we not need normalized markers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the terminology I have used,
No other significance of it than grouping the scaled markers
If you could suggest the better naming for this?
Looks good apart from the two questions |
Description
Checklist: