Skip to content

chore: rename route interface #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2021
Merged

chore: rename route interface #966

merged 4 commits into from
Jul 6, 2021

Conversation

arjunlalb
Copy link
Contributor

Description

Renaming route interface

@arjunlalb arjunlalb requested a review from anandtiwary July 3, 2021 04:26
@arjunlalb arjunlalb requested a review from a team as a code owner July 3, 2021 04:26
@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #966 (8ba80cd) into main (07e9821) will not change coverage.
The diff coverage is 94.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #966   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files         812      812           
  Lines       16744    16744           
  Branches     2166     2166           
=======================================
  Hits        14240    14240           
  Misses       2473     2473           
  Partials       31       31           
Impacted Files Coverage Δ
...ojects/common/src/navigation/navigation.service.ts 85.71% <66.66%> (ø)
projects/common/src/feature/feature.guard.ts 93.10% <100.00%> (ø)
projects/common/src/public-api.ts 100.00% <100.00%> (ø)
...d-tracing/src/pages/spans/span-list.page.module.ts 100.00% <100.00%> (ø)
...src/pages/trace-detail/trace-detail.page.module.ts 100.00% <100.00%> (ø)
...s/api-trace-detail/api-trace-detail.page.module.ts 100.00% <100.00%> (ø)
src/app/home/home.module.ts 100.00% <100.00%> (ø)
src/app/shared/navigation/navigation.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e9821...8ba80cd. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 1b520d7 into main Jul 6, 2021
@arjunlalb arjunlalb deleted the rename-route-interface branch July 6, 2021 20:08
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

Unit Test Results

    4 files  ±0  259 suites  ±0   16m 10s ⏱️ +14s
938 tests ±0  938 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
944 runs  ±0  944 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1b520d7. ± Comparison against base commit 07e9821.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants