feat: move a common method into navigation service #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 85.04% 85.04%
=======================================
Files 812 812
Lines 16744 16745 +1
Branches 2166 2166
=======================================
+ Hits 14240 14241 +1
Misses 2473 2473
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
itssharmasandeep
previously approved these changes
Jul 6, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
itssharmasandeep
previously approved these changes
Jul 6, 2021
anandtiwary
reviewed
Jul 6, 2021
anandtiwary
reviewed
Jul 6, 2021
| @@ -229,6 +231,26 @@ export class NavigationService { | |||
| return this.findRouteConfig(path, childRoutes ? childRoutes : []); | |||
| } | |||
|
|
|||
| public decorateNavItem(navItem: NavItemConfig, activatedRoute: ActivatedRoute): NavItemConfig { | |||
There was a problem hiding this comment.
can we add some tests for these two methods since they are shared? Can do it in a follow up PR?
anandtiwary
previously approved these changes
Jul 6, 2021
arjunlalb
dismissed stale reviews from anandtiwary and itssharmasandeep
via
1048eca
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
itssharmasandeep
approved these changes
Jul 7, 2021
This comment has been minimized.
This comment has been minimized.
This was referenced Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor refactor
Testing
UT added
Checklist: