Skip to content

refactor: entity changes for api-dashboard #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Conversation

anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jul 7, 2021

Description

Please include a summary of the change, motivation and context.
refactor: entity changes for api-dashboard

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner July 7, 2021 18:35
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #978 (594d987) into main (cea9d92) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #978   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files         812      812           
  Lines       16754    16754           
  Branches     2168     2168           
=======================================
  Hits        14250    14250           
  Misses       2473     2473           
  Partials       31       31           
Impacted Files Coverage Δ
...nents/entity-renderer/entity-renderer.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea9d92...594d987. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 4fbcc37 into main Jul 9, 2021
@anandtiwary anandtiwary deleted the entity-changes branch July 9, 2021 01:21
@github-actions
Copy link

github-actions bot commented Jul 9, 2021

Unit Test Results

    4 files  ±0  259 suites  ±0   14m 0s ⏱️ -41s
940 tests ±0  940 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
946 runs  ±0  946 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4fbcc37. ± Comparison against base commit cea9d92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants