Skip to content

feat: explore query builder #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2021
Merged

feat: explore query builder #981

merged 3 commits into from
Jul 9, 2021

Conversation

itssharmasandeep
Copy link
Contributor

Description

Explore query builder

Testing

Local testing done.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner July 9, 2021 07:44
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #981 (fed0ce4) into main (344d5b6) will increase coverage by 0.01%.
The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
+ Coverage   85.05%   85.07%   +0.01%     
==========================================
  Files         812      814       +2     
  Lines       16756    16773      +17     
  Branches     2169     2169              
==========================================
+ Hits        14252    14269      +17     
  Misses       2473     2473              
  Partials       31       31              
Impacted Files Coverage Δ
...i-calls-count/api-calls-count-data-source-model.ts 100.00% <ø> (ø)
...hql/explore/explore-cartesian-data-source.model.ts 89.39% <ø> (ø)
...d/dashboard/data/graphql/explore/explore-result.ts 100.00% <ø> (ø)
...lorer-visualization-cartesian-data-source.model.ts 84.21% <ø> (ø)
...ggregation/metric-aggregation-data-source.model.ts 100.00% <ø> (ø)
...l/table/explore/explore-table-data-source.model.ts 75.00% <ø> (ø)
...aphql/trace/donut/trace-donut-data-source.model.ts 100.00% <ø> (ø)
...eries/trace-metric-timeseries-data-source.model.ts 87.50% <ø> (ø)
...hql/trace/trace-series-values-data-source.model.ts 88.88% <ø> (ø)
...ata/graphql/trace/trace-value-data-source.model.ts 100.00% <ø> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344d5b6...fed0ce4. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@itssharmasandeep itssharmasandeep merged commit 145f8cf into main Jul 9, 2021
@itssharmasandeep itssharmasandeep deleted the explore-query-builder branch July 9, 2021 14:59
@github-actions
Copy link

github-actions bot commented Jul 9, 2021

Unit Test Results

    4 files  ±0  259 suites  ±0   14m 58s ⏱️ - 1m 19s
941 tests ±0  941 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
947 runs  ±0  947 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 145f8cf. ± Comparison against base commit 344d5b6.


private getAnyIntervalSelections(request: GraphQlExploreRequest): GraphQlSelection[] {
return request.interval ? [{ path: 'intervalStart', alias: INTERVAL_START_QUERY_KEY }] : [];
return this.exploreGraphQlQueryBuilderService.buildResponse(response, request);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query is just the query. If you want to include response code too, then <>RequestResponseBuilder would have been more clear. We can change it later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants