fix: wrong tooltip in radar chart in firefox #990
Conversation
| @@ -15,7 +15,7 @@ export class RadialDataLookupStrategy { | |||
|
|
|||
| public constructor(private readonly allSeries: RadarSeries[], radialAxisData: RadarAxisData[]) { | |||
| this.radialBisector = bisector(axisData => axisData.axisRadian); | |||
| this.radialAxisData = clone(radialAxisData); | |||
| this.radialAxisData = clone(radialAxisData.sort(axisData => axisData.axisRadian)); | |||
There was a problem hiding this comment.
please sort the cloned array instead of the argument
There was a problem hiding this comment.
Out of curiosity, if this data is not sorted why is this not an issue in other browsers?
There was a problem hiding this comment.
It is sorted in other browsers like chrome and safari.
Without the fix, in chrome radialAxisData, is sorted by axisRadian
The same code in firefox returns radialAxisData is not sorted
There was a problem hiding this comment.
oh strange - thanks for explaining!
Codecov Report
@@ Coverage Diff @@
## main #990 +/- ##
=======================================
Coverage 85.07% 85.07%
=======================================
Files 814 814
Lines 16773 16773
Branches 2169 2169
=======================================
Hits 14269 14269
Misses 2473 2473
Partials 31 31
Continue to review full report at Codecov.
|
projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts
Outdated
Show resolved
Hide resolved
projects/observability/src/shared/components/radar/tooltip/radial-data-lookup-strategy.ts
Outdated
Show resolved
Hide resolved
|
Welcome and thanks @jyothishjose6190 ! |
thank you |
Description
In Firefox alone, wrong tooltip was shown for radar chart
Testing
Run all test cases using npm run lint && npm run test
Checklist: