Skip to content

feat(mobile): sqlite asset viewer #19552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jul 2, 2025
Merged

feat(mobile): sqlite asset viewer #19552

merged 29 commits into from
Jul 2, 2025

Conversation

shenlong-tanwen
Copy link
Member

No description provided.

@shenlong-tanwen
add full image provider and refactor thumb providers
d522dd9
@shenlong-tanwen
photo_view updates
ec68749
@shenlong-tanwen
wip: asset-viewer
50c383e
@shenlong-tanwen
fix controller dispose on page change
699b6b2
@shenlong-tanwen
wip: bottom sheet
1fb7d26
@shenlong-tanwen
fix interactions
af4a347
@shenlong-tanwen
Merge branch 'main' into feat/mobile-asset-viewer
1a093ea 
# Conflicts:
#	mobile/lib/infrastructure/repositories/storage.repository.dart
#	mobile/lib/presentation/widgets/images/local_thumb_provider.dart
#	mobile/lib/presentation/widgets/images/remote_thumb_provider.dart
#	mobile/lib/presentation/widgets/images/thumbnail_tile.widget.dart
#	mobile/lib/presentation/widgets/timeline/fixed/segment.model.dart
#	mobile/lib/routing/router.dart
@shenlong-tanwen
more bottomsheet changes
f3fcc37
@shenlong-tanwen
generate schema
e2a782d
@alextran1502
Copy link
Member

alextran1502 commented Jun 26, 2025 •
edited
Loading

Ganka, great work as always! First round of testing, and I have a few comments

  1. The pinch-to-zoom action is making the image rotate in the horizontal direction (noticeable if the image is vertical); we should clamp it to zoom only in the vertical direction
  2. When swiping up, the image should be pushed up halfway to avoid showing the top rectangle corners. This means the bottom sheet should be opened at 2/3 of the screensize initially
  3. When the bottom sheet is opened, a small margin is visible around the image. Can we expand the image fully to avoid the margin there?
  4. The swipe down action should dismiss the bottom sheet entirely, and return the image to its original position, i.e., we want snapping here
  5. The threshold of swiping down to return to the timeline should be reduced. Ideally, you want to flick your finger and still make that action happen

@alextran1502 alextran1502 mentioned this pull request Jun 30, 2025
Open
4 tasks
@shenlong-tanwen shenlong-tanwen marked this pull request as ready for review July 1, 2025 20:06
@shenlong-tanwen shenlong-tanwen mentioned this pull request Jul 2, 2025
Merged
@shenlong-tanwen shenlong-tanwen enabled auto-merge (squash) July 2, 2025 18:23
@shenlong-tanwen shenlong-tanwen merged commit 7855974 into main Jul 2, 2025
47 checks passed
@shenlong-tanwen shenlong-tanwen deleted the feat/mobile-asset-viewer branch July 2, 2025 18:24
danieldietzler pushed a commit that referenced this pull request Jul 8, 2025
@shenlong-tanwen @alextran1502 @danieldietzler
feat(mobile): sqlite asset viewer (#19552)
8ee6704 
* add full image provider and refactor thumb providers

* photo_view updates

* wip: asset-viewer

* fix controller dispose on page change

* wip: bottom sheet

* fix interactions

* more bottomsheet changes

* generate schema

* PR feedback

* refactor asset viewer

* never rotate and fix background on page change

* use photoview as the loading builder

* precache after delay

* claude: optimizing rebuild of image provider

* claude: optimizing image decoding and caching

* use proper cache for new full size image providers

* chore: load local HEIC fullsize for iOS

* make controller callbacks nullable

* remove imageprovider cache

* do not handle drag gestures when zoomed

* use loadOriginal setting for HEIC / larger images

* preload assets outside timer

* never use same controllers in photo-view gallery

* fix: cannot scroll down once swipe with bottom sheet

---------

Co-authored-by: shenlong-tanwen <[email protected]>
Co-authored-by: Alex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

Assignees
No one assigned
Labels
changelog:skip 📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenlong-tanwen @alextran1502