chore(authenticator): fix authenticator task being dropped #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
force-pushed
the
evalir/chore-authenticator-hold-and-not-drop-futures-immediately
branch
from
b37784e to
5c8fab5
Compare
Evalir
changed the title
…-futures-immediately
anna-carroll
approved these changes
Dec 9, 2024
Evalir
changed the title
dylanlott
approved these changes
Dec 9, 2024
anna-carroll
deleted the
evalir/chore-authenticator-hold-and-not-drop-futures-immediately
branch
Evalir
restored the
evalir/chore-authenticator-hold-and-not-drop-futures-immediately
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
select!block was returning early because thespawnfn of theauthenticatortask was a future being awaited, instead of just returning the join handle.