Skip to content

fix: construct v properly relative to upstream api changes #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

rswanson
Copy link
Member

No description provided.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, approving when we get the unit test

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit

@rswanson rswanson requested a review from Evalir January 14, 2025 17:14
@rswanson rswanson self-assigned this Jan 14, 2025
@rswanson rswanson enabled auto-merge (squash) January 14, 2025 17:19
@rswanson rswanson merged commit 56371c8 into main Jan 14, 2025
5 checks passed
@rswanson rswanson deleted the swanny/fix-reverts branch January 14, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants