adds checks before attempting to connect broadcast providers #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- checks for empty string before attempting to connect to providers in the tx_broadcast_urls configuration field
| let provider = | ||
| ProviderBuilder::new().on_builtin(url).await.map_err(Into::<ConfigError>::into)?; | ||
| providers.push(provider); | ||
| if !self.tx_broadcast_urls.is_empty() && self.tx_broadcast_urls[0] != "" { |
There was a problem hiding this comment.
should we just do this when we actually populate self.tx_broadcast_urls?
There was a problem hiding this comment.
There was a problem hiding this comment.
Sure, that works too. I was thinking about the case where we wanted to do additional setup or validation with the URLs but this works.
|
closing in favor of #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
checks for empty string before attempting to create providers from the builder's tx_broadcast_urls configuration field.