Skip to content

Commit 0c2f83e

Browse files
committed
Fixed coverity issue in acl_kernel_if.cpp: Type: Reliance on integer endianness (INCOMPATIBLE_CAST)
1 parent 064ce87 commit 0c2f83e

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

src/acl_kernel_if.cpp

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,8 @@ static int acl_kernel_if_read_32b(acl_kernel_if *kern, unsigned int addr,
288288
r = kern->io.read(&kern->io, (dev_addr_t)addr, (char *)val, (size_t)size);
289289
if (r < size) {
290290
kern->io.printf(
291-
"HAL Kern Error: Read failed from addr %x, read %zu expected %zu\n", addr,
292-
r, size);
291+
"HAL Kern Error: Read failed from addr %x, read %zu expected %zu\n",
292+
addr, r, size);
293293
return -1;
294294
}
295295
return 0;
@@ -334,8 +334,8 @@ static int acl_kernel_rom_read_block(acl_kernel_if *kern, unsigned int addr,
334334
r = kern->io.read(&kern->io, (dev_addr_t)addr, config_rom, (size_t)size);
335335
if (r < size) {
336336
kern->io.printf(
337-
"HAL Kern Error: Read failed from addr %x, read %zu expected %zu\n", addr,
338-
r, size);
337+
"HAL Kern Error: Read failed from addr %x, read %zu expected %zu\n",
338+
addr, r, size);
339339
return -1;
340340
}
341341
return 0;
@@ -451,8 +451,8 @@ static uintptr_t acl_kernel_cra_set_segment(acl_kernel_if *kern,
451451
acl_kernel_if_write_32b(kern, OFFSET_KERNEL_CRA_SEGMENT,
452452
(unsigned int)segment);
453453
kern->cur_segment = segment;
454-
acl_kernel_if_read_32b(kern, OFFSET_KERNEL_CRA_SEGMENT,
455-
(unsigned int *)&segment);
454+
unsigned int new_segment = (unsigned int)segment;
455+
acl_kernel_if_read_32b(kern, OFFSET_KERNEL_CRA_SEGMENT, &new_segment);
456456
}
457457

458458
return segment_offset;
@@ -468,8 +468,8 @@ static uintptr_t acl_kernel_cra_set_segment_rom(acl_kernel_if *kern,
468468
acl_kernel_if_write_32b(kern, OFFSET_KERNEL_CRA_SEGMENT,
469469
(unsigned int)segment);
470470
kern->cur_segment = segment;
471-
acl_kernel_if_read_32b(kern, OFFSET_KERNEL_CRA_SEGMENT,
472-
(unsigned int *)&segment);
471+
unsigned int new_segment = (unsigned int)segment;
472+
acl_kernel_if_read_32b(kern, OFFSET_KERNEL_CRA_SEGMENT, &new_segment);
473473
}
474474

475475
return segment_offset;
@@ -1613,8 +1613,9 @@ void acl_kernel_if_update_status(acl_kernel_if *kern) {
16131613
acl_kernel_if_write_32b(kern, OFFSET_KERNEL_CRA_SEGMENT,
16141614
(unsigned int)segment_pre_irq);
16151615
kern->cur_segment = segment_pre_irq;
1616+
unsigned int new_segment_pre_irq = (unsigned int)segment_pre_irq;
16161617
acl_kernel_if_read_32b(kern, OFFSET_KERNEL_CRA_SEGMENT,
1617-
(unsigned int *)&segment_pre_irq);
1618+
&new_segment_pre_irq);
16181619
}
16191620
}
16201621

0 commit comments

Comments
 (0)