kernel_if: factor out CSR-dependent status handling #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Colberg <[email protected]>
Signed-off-by: Peter Colberg <[email protected]>
Keep zeroing upper bits since `unsigned int` may be larger than 32 bits. Signed-off-by: Peter Colberg <[email protected]>
… status Signed-off-by: Peter Colberg <[email protected]>
… invocation Signed-off-by: Peter Colberg <[email protected]>
sophimao
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors out the CSR-dependent status handling of pending kernel invocations into separate functions, prerequisite to #103.
The refactoring is cosmetic, with the exception of when
kern->last_kern_updateis updated. Before, when the CSR done bit was set to signal that an invocation was finished but the finish counter was read as zero,kern->last_kern_updatewould still be updated. Now,kern->last_kern_updateis not updated when the finish counter is read as zero. In practice, this change should not have any effect too, since the finish counter should never be zero when the CSR done bit is set; however the runtime does not check whether the finish counter is indeed nonzero.