Skip to content

Resolve address sanitizer issues in runtime unit test #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 18, 2022

Conversation

sophimao
Copy link
Contributor

Resolves #120

@pcolberg pcolberg added the bug Something isn't working label Aug 12, 2022
@pcolberg pcolberg added this to the 2023.0 milestone Aug 12, 2022
@sophimao sophimao requested review from pcolberg and zibaiwan August 12, 2022 14:15
@sophimao
Copy link
Contributor Author

While I was fixing the issue, I found that the condition on acl_mem.cpp:1631 seems exactly like the previous condition on lines 1624-1625. Should that be an is_image condition?

@pcolberg
Copy link
Contributor

While I was fixing the issue, I found that the condition on acl_mem.cpp:1631 seems exactly like the previous condition on lines 1624-1625. Should that be an is_image condition?

Thanks Sophie, good catch! Looking at the list of possible memory object types, can these two cases be combined to a single case, image_desc->mem_object != NULL and Do not support images created from other memory objects?

@sophimao
Copy link
Contributor Author

While I was fixing the issue, I found that the condition on acl_mem.cpp:1631 seems exactly like the previous condition on lines 1624-1625. Should that be an is_image condition?

Thanks Sophie, good catch! Looking at the list of possible memory object types, can these two cases be combined to a single case, image_desc->mem_object != NULL and Do not support images created from other memory objects?

I guess we could do that. I'm wondering what's the original intend of having two separate conditions though, perhaps we are thinking of supporting those two cases one by one? If we do want to look into supporting that, maybe it's good to keep an investigation note somewhere.

Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sophie! I can't wait to enable the asan workflow 🙂

@pcolberg pcolberg merged commit 1847ee9 into intel:main Aug 18, 2022
@sophimao sophimao deleted the asan branch August 19, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass runtime tests with address sanitizer
3 participants