-
Notifications
You must be signed in to change notification settings - Fork 71
Resolve address sanitizer issues in runtime unit test #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While I was fixing the issue, I found that the condition on acl_mem.cpp:1631 seems exactly like the previous condition on lines 1624-1625. Should that be an |
Thanks Sophie, good catch! Looking at the list of possible memory object types, can these two cases be combined to a single case, |
I guess we could do that. I'm wondering what's the original intend of having two separate conditions though, perhaps we are thinking of supporting those two cases one by one? If we do want to look into supporting that, maybe it's good to keep an investigation note somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sophie! I can't wait to enable the asan workflow 🙂
…to cl_sampler without checking
…l_int to a cl_command_queue without checking
Resolves #120