Skip csr version check when cra_ring_root doesn't exist #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zibaiwan
force-pushed
the
remove-csr-version-check
branch
from
2ccac09 to
9966787
Compare
zibaiwan
force-pushed
the
remove-csr-version-check
branch
from
9966787 to
4774009
Compare
zibaiwan
force-pushed
the
remove-csr-version-check
branch
2 times, most recently
from
eb29930 to
348c8a6
Compare
zibaiwan
force-pushed
the
remove-csr-version-check
branch
from
348c8a6 to
3eaf6ce
Compare
pcolberg
previously approved these changes
Nov 8, 2022
|
Integration test failed due to the assertion in the |
zibaiwan
force-pushed
the
remove-csr-version-check
branch
2 times, most recently
from
bc237cb to
b840804
Compare
zibaiwan
force-pushed
the
remove-csr-version-check
branch
from
b840804 to
63d6a70
Compare
pcolberg
reviewed
Nov 9, 2022
zibaiwan
force-pushed
the
remove-csr-version-check
branch
2 times, most recently
from
3007898 to
ce1f640
Compare
1. Parse the new field from the auto-discovery string 2. Changed csr_version to be optional. 3.Skip csr version check if cra_ring_root doesn't exit. 4.Update the forward-compatibility auto-discovery string test. Note:previous test had an issue: The number of fields per device global is fixed (here to 1), not variable. I had to update that as well. 5.Add new unit tests.
zibaiwan
force-pushed
the
remove-csr-version-check
branch
from
ce1f640 to
d431835
Compare
pcolberg
approved these changes
Nov 14, 2022
|
Test results look good. Merging into the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the system integrator, in the auto-discovery string, added a new field at the end of the device section to indicate whether the cra_ring_root exist or not. The runtime will parse the new field from the auto-discovery string and skip csr version check if cra_ring_root doesn't exit. Changed the csr_version to be optional.
Updated the forward-compatibility auto-discovery string test. Note: the previous test had an issue: The number of fields per device global is fixed (here to 1), not variable. I had to update that as well. Cherry picked from: 024154d