Fixed coverity in acl_globals.cpp #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoxian2
force-pushed
the
coverity-acl-globals
branch
from
50231ca to
201cb25
Compare
…TURN) The function acl_init_from_hal_discovery that contains the acl_set_hal issue is initializing the HAL and load the builtin system definition. acl_set_hal returns 0 if HAL is unvalid. Therefore, I believe that if the HAL is not valid, it should be considered as uninitialized since we cannot fetch the correct builtin system definition.
haoxian2
force-pushed
the
coverity-acl-globals
branch
from
201cb25 to
949c628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed coverity in acl_globals.cpp: Unchecked return value (CHECKED_RETURN)
Coverity was complaining that
acl_set_halfunction return value was not checked. The functionacl_init_from_hal_discoverythat contains theacl_set_halissue is initializing the HAL and load the builtin system definition.acl_set_halreturns0if HAL is unvalid. Since the HAL is normally just set once on startup and then not changed, I believe that if the HAL is not valid, it should be considered as uninitialized since we cannot fetch the correct builtin system definition.