hal_mmd: remove support for dynamically loading custom non-MMD libraries #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a dynamically loaded MMD library did not export the MMD API, tested by the absense of aocl_mmd_get_offline_info(), the runtime would reload the library into the global lookup scope, with the intention of providing the symbols to another, actual MMD library. Since this feature was never documented or used in a reference BSP, it should be safe to remove and avoid polluting the global scope. As an alternative, an MMD library requiring additional symbols could dynamically link with the corresponding shared library at build time. Signed-off-by: Peter Colberg <[email protected]>
|
This is a prerequisite of #227. |
pcolberg
commented
Feb 1, 2023
|
I will merge this once hardware testing is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dynamically loaded MMD library did not export the MMD API, tested by the absense of aocl_mmd_get_offline_info(), the runtime would reload the library into the global lookup scope, with the intention of providing the symbols to another, actual MMD library.
Since this feature was never documented or used in a reference BSP, it should be safe to remove and avoid polluting the global scope. As an alternative, an MMD library requiring additional symbols could dynamically link with the corresponding shared library at build time.
Signed-off-by: Peter Colberg [email protected]