Fix simulation of multi-memory systems #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the runtime is initialized it needs to advertise the available devices. For hardware this is fine because we can query the hardware via PCIe, but for the simulation flow we don't know what the board should look like until we receive an aocx file. To work around this restriction, we initialize the simulation flow using the autodiscovery string for the a10gx board. This is often fine, but in cases where we want to simulate a board with more memory systems we will encounter an issue. In particular, targeting different `buffer_location`s in the source will often result in this assertion: ``` /src/acl_device_op.cpp:677: int l_is_noop_migration(acl_device_op_t*): Assertion `src_mem->reserved_allocations[dest_device].size() > dest_mem_id' failed. ``` Ideally we would want to allocate this space dynamically based on the .aocx file; however, we get the .aocx file quite late for simulation flow, after we have already created buffers.
zibaiwan
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the runtime is initialized it needs to advertise the available
devices. For hardware this is fine because we can query the hardware
via PCIe, but for the simulation flow we don't know what the board
should look like until we receive an aocx file. To work around this
restriction, we initialize the simulation flow using the autodiscovery
string for the a10gx board. This is often fine, but in cases where we
want to simulate a board with more memory systems we will encounter an
issue. In particular, targeting different
buffer_locations in thesource will often result in this assertion:
Ideally we would want to allocate this space dynamically based on the
.aocx file; however, we get the .aocx file quite late for simulation
flow, after we have already created buffers.