Skip to content

Add support for hostpipe sideband signals. #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

zibaiwan
Copy link
Contributor

@zibaiwan zibaiwan commented Oct 25, 2023

  1. Parsed the new autodiscovery information, and record the side band signal information in the runtime host pipe struct

  2. Upon writing to the host pipes, parse the data packet received from SYCL into a data portion and individual side band signals using the offset information (do the opposite for reading: construct the data packet from the data and individual side band signals)

  3. Added call(s) to aocl_mmd_hostchannel_get_sideband_buffer when pushing/pulling packets with side band signals, write to/read from this buffer with the side band signal values.

  4. Acknowledge the read/write after all sideband signals and data finished read/write.

@zibaiwan zibaiwan force-pushed the sideband branch 2 times, most recently from 7561ef3 to 1304090 Compare October 30, 2023 18:28
@zibaiwan zibaiwan changed the title Don't review, sideband signal testing draft PR Add support for hostpipe sideband signals. Oct 30, 2023
@zibaiwan zibaiwan marked this pull request as ready for review October 30, 2023 18:31
@zibaiwan zibaiwan requested a review from sophimao October 31, 2023 14:29
Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai! Overall looks good to me, and I have left some comments below.

Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai, looks good to me!

@zibaiwan zibaiwan merged commit 35e2f84 into intel:main Nov 3, 2023
@zibaiwan zibaiwan deleted the sideband branch November 3, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants