Update MMD versioning scheme #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophimao
force-pushed
the
update-mmd-version
branch
2 times, most recently
from
d580bda to
4e50f67
Compare
zibaiwan
reviewed
Mar 18, 2024
sophimao
force-pushed
the
update-mmd-version
branch
3 times, most recently
from
125e290 to
9da3ad0
Compare
sophimao
commented
Mar 25, 2024
aktole
approved these changes
Mar 25, 2024
Right, or unless they set it to some jibber-jabber that cannot be converted to a floating point number, which I don't think will happen very often :p |
|
Hi Sophie, Is this planned to go to 2024.2 release? Thanks, Zibai |
Chatted with Sophie offline. This will go to Trunk first and then cherry-picked into 2024.2 depends on the full test results. I am reviewing the change, so far looks good to me. Will do a more thorough review and should be done by tomorrow. |
This change also: - Determines MMD buffer location support based on MMD verison - Formally define host pipe side band port id in aocl_mmd.h - Support querying buffer location on host/shared USM allocation
sophimao
force-pushed
the
update-mmd-version
branch
from
9da3ad0 to
f05e6d4
Compare
zibaiwan
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #147 by deciding buffer location support based on the MMD version.
With the new versioning scheme, MMDs starting from version 2024.2 should be supporting buffer location and accepting the buffer location property.