Return the global memory with enough capacity as default mem_id #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophimao
force-pushed
the
agilex_hetero_diag
branch
from
bda6ec5 to
2c38a36
Compare
sophimao
requested review from
mendell27 and
justin-rosner
and removed request for
rho180
mendell27
approved these changes
Jun 10, 2024
sophimao
force-pushed
the
agilex_hetero_diag
branch
from
2c38a36 to
7e5800e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For heterogeneous memory system where each global memory has the same size, the memory with address range starting at 0x0 may have a smaller usable range than the other memories as we need to avoid allocating at 0x0. As a result, if user allocates a buffer with size of CL_DEVICE_MAX_MEM_ALLOC_SIZE, it will need to be allocated to one of the other memories. This change updates the way default
gmem_idis found, by taking the allocation size into account.